[MNG-7646] Do not parse all projects in the reactor when building a subtree#963
Merged
gnodet merged 1 commit intoapache:masterfrom Jan 26, 2023
Merged
[MNG-7646] Do not parse all projects in the reactor when building a subtree#963gnodet merged 1 commit intoapache:masterfrom
gnodet merged 1 commit intoapache:masterfrom
Conversation
gnodet
force-pushed
the
MNG-7646
branch
4 times, most recently
from
0819759 to
acf32e9
Compare
gnodet
requested review from
MartinKanters and
mthmulders
and removed request for
MartinKanters
cstamas
approved these changes
Jan 25, 2023
mthmulders
approved these changes
Jan 26, 2023
Contributor
mthmulders
left a comment
mthmulders
left a comment
There was a problem hiding this comment.
Nice improvement!
I've tested by building (mvn test) a particular module of a larger project, while a different module of the same project had an XML error. The build did not fail, until I ran mvn -am test. That gave a failing build because the other module POM could not be parsed.
|
Resolve #8807 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to MNG-7629 and #954, the idea for this PR is to not parse all the reactor.
The idea of this PR is to parse all projects from the reactor only if the makeBehavior is set (i.e.
-amand/or-amdoption has been used), or if a project activation has been set (i.e.-pl,-ror-rfis used). Note that parents are always resolved from the file system, even if not included in the reactor.The ITs only require a single modification: apache/maven-integration-testing#239