This repository was archived by the owner on Aug 20, 2025. It is now read-only.
METRON-1560: Update MPack to support Pcap panel#1124
Closed
merrimanr wants to merge 62 commits intoapache:feature/METRON-1554-pcap-query-panelfrom
Closed
METRON-1560: Update MPack to support Pcap panel#1124merrimanr wants to merge 62 commits intoapache:feature/METRON-1554-pcap-query-panelfrom
merrimanr wants to merge 62 commits intoapache:feature/METRON-1554-pcap-query-panelfrom
Conversation
Pcap job manager generics from cestella
…r for synchronicity. Kill remnants of the job service.
…into pcap-job-manager
Get PcapTopologyIntegrationTest working
…into pcap-job-manager
# Conflicts: # metron-interface/metron-rest/src/main/java/org/apache/metron/rest/MetronRestConstants.java # metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/PcapController.java # metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/PcapService.java # metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/PcapServiceImpl.java # metron-interface/metron-rest/src/main/resources/application.yml # metron-interface/metron-rest/src/test/java/org/apache/metron/rest/service/impl/PcapServiceImplTest.java
# Conflicts: # metron-interface/metron-rest/src/test/java/org/apache/metron/rest/service/impl/PcapServiceImplTest.java
…r cestella request.
…into pcap-job-manager
# Conflicts: # metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/PcapServiceImpl.java
# Conflicts: # metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/PcapServiceImpl.java
…anel' into METRON-1685 # Conflicts: # metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/PcapController.java # metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/PcapService.java # metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/PcapServiceImpl.java # metron-interface/metron-rest/src/test/java/org/apache/metron/rest/config/TestConfig.java # metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/PcapControllerIntegrationTest.java # metron-interface/metron-rest/src/test/java/org/apache/metron/rest/service/impl/PcapServiceImplTest.java # metron-platform/metron-job/src/main/java/org/apache/metron/job/manager/InMemoryJobManager.java
…anel' into METRON-1560
…anel' into METRON-1560
Member
|
+1 by inspection; this puts a nice bow on the backend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor Comments
This PR adds MPack support for the Pcap query feature. The pcap properties in application.yml are now exposed in Ambari. The page size can be changed in the REST tab while the paths (changing them shouldn't be common) can be done in the Advanced tab.
Changes Included
Testing
This has been tested in full dev. Testing is similar very similar to #1123 and #1120. The only difference is that creating the HDFS directories in Step 2 is no longer required.
As an additional test, change the Pcap Page Size setting in the REST Configs tab in Ambari. After running a query the number of pages should reflect the page size.
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:
For code changes:
Have you included steps to reproduce the behavior or problem that is being changed or addressed?
Have you included steps or a guide to how the change may be verified and tested manually?
Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
Have you written or updated unit tests and or integration tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
For documentation related changes:
Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via
site-book/target/site/index.html:Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.