Skip to content
This repository was archived by the owner on Aug 20, 2025. It is now read-only.

Conversation

@justinleet
Copy link
Contributor

@justinleet justinleet commented Sep 13, 2018

Contributor Comments

Noticed that a couple images have been broken through at least the 0.5.0 release, but didn't want to hold up the 0.6.0 release.

This makes the manual changes necessary to get it working again in generate-md.sh.

Please check out https://cwiki.apache.org/confluence/display/METRON/Website+PR+Merge for instructions on how to spin it up.

Just click through all the pages. No errors should occur on the command line related to a file not found.

Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

  • Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
  • Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

  • Have you included steps to reproduce the behavior or problem that is being changed or addressed?
  • Have you included steps or a guide to how the change may be verified and tested manually?
  • Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
    mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
    

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:

    cd site-book
    mvn site
    

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

@mmiklavc
Copy link
Contributor

+1, thanks @justinleet.

Verified this by clicking through all links on the main website as well as the site-book. It wasn't immediately clear to me from the PR description, but looking at the diff changes this appears to address issues specific to the site-book, in particular under the use-cases section.

@asfgit asfgit closed this in 02a1280 Sep 17, 2018
MohanDV pushed a commit to MohanDV/metron that referenced this pull request Sep 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants