Skip to content
This repository was archived by the owner on Aug 20, 2025. It is now read-only.

Conversation

@nickwallen
Copy link
Contributor

@nickwallen nickwallen commented Oct 11, 2018

This refactors the various ElasticsearchWriter settings so they are all defined in a single place as constants. There is no functional change. This is simply a refactor.

This is the refactor I was looking at doing for #1218, but decided to keep it separate to simplify the review process.

Testing

  1. Spin-up the development environment.

  2. Ensure alerts are visible in the Alerts UI.

Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

  • Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
  • Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

  • Have you included steps to reproduce the behavior or problem that is being changed or addressed?

  • Have you included steps or a guide to how the change may be verified and tested manually?

  • Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:

    mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
    
  • Have you written or updated unit tests and or integration tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

  • Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

@justinleet
Copy link
Contributor

@mmiklavc You were looking at migration of some of the ES stuff, right? Is this something worth pulling in with your changes, or should we just hold off for now?

@mmiklavc
Copy link
Contributor

@justinleet correct, I have a number of changes that will overlap with or replace this in the ES client upgrade/migration. In particular the utils class changes.

@nickwallen nickwallen closed this Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants