Skip to content
This repository was archived by the owner on Aug 20, 2025. It is now read-only.

Conversation

@nickwallen
Copy link
Contributor

@nickwallen nickwallen commented Nov 14, 2018

There are some log4j dependencies in the metron-elasticsearch that cause problems when attempting to run the Elasticsearch integration tests from an IDE like Intellij. These dependencies are unnecessary and should be removed for that reason alone. But additionally this fix lets you run the tests from Intellij.

This was previously included in #1218 before that was backed out of master.

Testing

Integration Tests

  1. Load up the code in an IDE like IntelliJ.
  2. Execute the tests in metron-platform/metron-elasticsearch/src/tests.
  3. The tests should all run successfully.

Test Deployment

  1. Spin-up Full Dev.
  2. Ensure alerts are visible in the Alerts UI.

Pull Request Checklist

  • Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
  • Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Have you included steps to reproduce the behavior or problem that is being changed or addressed?
  • Have you included steps or a guide to how the change may be verified and tested manually?
  • Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
  • Have you written or updated unit tests and or integration tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

@merrimanr
Copy link
Contributor

I find myself commenting these out every time I run ES integration tests in my IDE. +1

@nickwallen
Copy link
Contributor Author

This was taken care of in #1242 . No need.

@nickwallen nickwallen closed this Nov 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants