METRON-1932: Update ES and Kibana to 5.6.14 #1296
Conversation
|
This should be ready for review. |
|
are you going to update the metron-contrib/docker ? |
|
I didn't expect that would need an update. In looking at it, they've released a 5.6.14 which I'm going to move things to. |
JonZeolla
changed the title
|
@ottobackwards Is this what you would expect to upgrade docker? I'll have to spin it up later. Looks like that got missed in the initial move to 5.6. |
|
actually, I don't think you should touch it. although there might be a follow on jira for that stuff |
|
Why not? It makes sense to me that it should be kept in sync. |
|
I thought we put that in contrib so that it didn't need to be maintained? |
|
I'm sorry, I've made a mess of this. I should not have mentioned it. @merrimanr is right, this should be done in a separate pr |
|
Since it sounds like ES is broken in metron-contrib/metron-docker I'm not going to look to fix it here. Reverted |
|
@JonZeolla, thanks for doing this! We had hoped that moving to the ES client would make updating patch releases a lot easier, and that appears to be the case. For a minor patch version, I'd expect no breaking changes, but before I +1 this can you double check that nothing has changed around X-Pack and SSL connections? Any other upgrade notes we should be aware of? Also, can you update your notes in the initial comment 5.6.13 -> 5.6.14 to avoid confusion? |
|
Valid point. Updated my initial comment, can look at X-Pack and SSL. |
|
Do we have any previously used testing steps for X-Pack and/or SSL? I briefly looked at METRON-939 but didn't see anything. I can try to use some of the guidance from here if that's the best documentation. |
|
@JonZeolla - have a look at this - #1242 (comment) |
|
Aha perfect thank you I knew I read that somewhere in a PR before. |
|
First off, huge ty @mmiklavc for those great testing steps. It worked flawlessly, and I was able to confirm that both X-Pack and SSL work as expected as of HEAD of this branch. |
|
That's great @JonZeolla! Thanks for taking the extra time to verify this - I had originally anticipated just some release doc review on the ES side, but this is wonderful. Big +1 from me. We've touched on this before, but this work is yet another reason we might want to take another look at dev docs for testing in the project. Right now we hunt and search across old PR's for test scripts and that's probably time better spent simply keeping a core set of test instructions under version control. |
|
Thanks. Yeah, I started with the release doc review, which is what made me think this would be so straightforward. =) You are totally right. Is there a JIRA for that sort of follow-on? I really think that your steps should be captured somewhere for the future. |
|
I don't think so, but ping @ottobackwards as he's suggested we do this in the past. I've accidentally duplicated his Jiras before, so it's worth asking haha :-) |
|
I opened METRON-1943 to address my comment earlier:
|
|
I have not opened a jira on this, you may want to have a discuss. Unless we want to write a testing framework, where you can do common things and plugin scripts to validate etc etc |
4 participants
Contributor Comments
This upgrades ES and Kibana from 5.6.2 to 5.6.14, specifically with the goal to fix this which was backported to 5.6.4. Thanks to the great work in #1242 this was a piece of cake. I spun it up and poked around in ES, Kibana, the Alerts UI, and did some digging through logs looking for errors or warnings. Found some things that can be improved for the future, but don't appear to have been introduced by this PR.
Testing
Spin up full-dev, ensure ES/Kibana is healthy/working as expected, and is version 5.6.14.
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:
For code changes:
Have you included steps to reproduce the behavior or problem that is being changed or addressed?
Have you included steps or a guide to how the change may be verified and tested manually?
Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
Have you written or updated unit tests and or integration tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
For documentation related changes:
Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via
site-book/target/site/index.html:Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.