This repository was archived by the owner on Aug 20, 2025. It is now read-only.
METRON-2043 Fix profiler-client dependencies #1362
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickwallen
reviewed
Apr 9, 2019
| ClassIndexTransformer needs to go LAST. For some reason it will clobber other | ||
| transformers from operating when it is put first. | ||
| --> | ||
| <transformer implementation="org.atteo.classindex.ClassIndexTransformer"/> |
Contributor
There was a problem hiding this comment.
Was there a need to move ClassIndexTransformer first and remove the comment?
Contributor
Author
There was a problem hiding this comment.
@nickwallen - this was unintentional. I need to revert a couple changes here, merge in master again, and give this another kick.
Contributor
Author
|
Closing this PR - this was addressed in part via another fix here - #1525 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Comments
https://issues.apache.org/jira/browse/METRON-2043
This PR piggybacks off of the work in:
See the originating conversation for this PR here - #1358 (comment)
Note - I was able to remove the need to modify our license dependencies and maintain the flatfile_loader grabbing its hadoop/hbase deps directly from the provided distribution at runtime rather than having to bundle them directly. I also removed the assembly.xml from metron-profiler-client as all assembly-related work happens in other profiler modules.
Testing
I need to finish testing with the Stellar REPL, but preliminary tests on streaming enrichment and the flatfile_loader look good. Both work without error.
Follow test steps from:
Pull Request Checklist
For all changes:
For code changes:
Have you included steps to reproduce the behavior or problem that is being changed or addressed?
Have you included steps or a guide to how the change may be verified and tested manually?
Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
n/a Have you written or updated unit tests and or integration tests to verify your changes?
n/a If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
For documentation related changes:
n/a Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via
site-book/target/site/index.html:Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.