METRON-2090: Full dev is failing with missing org.mortbay.jetty:jetty-util:jar:6.1.26.hwx dependency

[merrimanr]

Contributor Comments

I was able to track this down to a special version of org.mortbay.jetty dependencies being pulled in by the org.apache.storm:storm-hdfs dependency: https://community.hortonworks.com/questions/6256/jetty-util-6126hwxjar.html

The org.mortbay.jetty dependencies are included transitively and the recent metron-writer pom.xml refactor in #1386 caused this special version to now be included. This PR fixes this by simply excluding the special version.

Testing

I was able to successfully build full dev and verified data was flowing through to HDFS and ES.

Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

• Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
• Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
• Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

• Have you included steps to reproduce the behavior or problem that is being changed or addressed?

• Have you included steps or a guide to how the change may be verified and tested manually?

• Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:

  mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
  

• Have you written or updated unit tests and or integration tests to verify your changes?

• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

• Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

• Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:

  cd site-book
  mvn site
  

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

[mmiklavc]

@merrimanr can you kick Travis? Seems like the tests got hung and timed out.

[merrimanr]

The latest travis failure was caused by new transitive dependencies being pulled in as a result of the initial changes in this PR. I don't think this is correct so I added the hadoop-common dependency before the storm-hdfs and that resolved the issue. We include hadoop-common near the top of several poms so I felt it was better to keep things consistent.

[mmiklavc]

@merrimanr +1. My full dev build was able to get past the previous build failure point. For added assurance, I also purged my Metron Maven artifacts from my local repo, i.e. rm -rf ~/.m2/repository/org/apache/metron and everything built as expected. Full dev comes up and the alerts UI displays the alerts listing as expected.

Let's get this merged asap. I think we definitely need this fix in for the 0.7.1 release.