This repository was archived by the owner on Aug 20, 2025. It is now read-only.
METRON-2161: CSS positioning bugs in Alerts and MGMT UI #1446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Comments
Link to ASF Jira ticket: https://issues.apache.org/jira/browse/METRON-2161
This PR fixes a handful of CSS bugs found in the Alerts and Management UI. I've included sceenshots/gifs below to show the issues and fixes.
Bug:
Fix in this PR:
Bug:
Fix in this PR:
Bug:
Fix in this PR:
Testing
All these changes can be tested manually with full dev. Please refer to the screenshots/gifs above for clarification on how it should look and behave.
Misaligned arrow in the datepicker: This can be seen by simply opening the Alerts UI and visually checking the button.
Saved searches panel opens from wrong side: Open the Alerts UI and click on the Saved Searches button. The panel should open from the left instead of the right.
Long message notification: This is a little trickier because message notifications only last for 5 seconds, and you will need to edit the message to simulate a long message. First, start the UI from
metron-interface/metron-configby runningnpm ciandscripts/start-dev.sh(this must be done so the UI can compile with the changes you're about to make in the next step). Open the alert file in metron-interface/metron-config/src/app/shared/metron-alerts.ts and update the SUCESS_MESSAGE_DISPALY_TIME const to something large (like 100000). Stop or start a parser. When the success message pops up, inspect the element and edit the content of the message in the browsers inspector. There should now be plenty of padding between the 'x' close button and the message. The message should also have margin on both the left and right side of it.Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:
For code changes:
Have you included steps to reproduce the behavior or problem that is being changed or addressed?
Have you included steps or a guide to how the change may be verified and tested manually?
Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
N/A
Have you written or updated unit tests and or integration tests to verify your changes?N/A
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
For documentation related changes:
N/A
Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes viasite-book/target/site/index.html:N/A
Have you ensured that any documentation diagrams have been updated, along with their source files, using draw.io? See Metron Development Guidelines for instructions.Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.