METRON-2183: Update to Angular v7

[sardell]

Contributor Comments

READ FIRST: This Pull Request seems very large, but a majority of the line changes are in the auto-generated package-lock.json file. There are less than one hundred lines of code changes outside of that auto-generated file. Now, breathe a sigh of relief. 😄

Link to original ASF ticket here.

Long term support for Angular v6 will end in November this year, so we should update what version we use. Per the suggestion of the Angular team, we should update to version 7 before updating to 8.

In this PR, I did exactly that and updated to version 7.2.15. In addition, I fixed a few unit tests that failed due to stricter type checking with the updated version of typescript (part of the Angular upgrade).

Testing

Spin up Full Dev as you normally would. All unit tests for the Alerts and Management UI should pass, as well as the Cypress e2e tests in the Alerts UI. If you open both UIs in the browser and open the dev tools console, you can run getAllAngularRootElements()[0].attributes["ng-version"]; to see what version of Angular is running. It should show 7.2.15.

Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

• Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
• Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
• Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

• Have you included steps to reproduce the behavior or problem that is being changed or addressed?

• Have you included steps or a guide to how the change may be verified and tested manually?

• Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:

  mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
  

• Have you written or updated unit tests and or integration tests to verify your changes?

• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

• Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

N/A - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:

cd site-book
mvn site

N/A - [ ] Have you ensured that any documentation diagrams have been updated, along with their source files, using draw.io? See Metron Development Guidelines for instructions.

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

[tiborm]

+1 (non-binding) I like that you upgraded both UIs!

[mmiklavc]

+1