This repository was archived by the owner on Aug 20, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 505
METRON-2225: Upgrade to Solr 7.4.0 #1492
Closed
merrimanr
wants to merge
6
commits into
apache:feature/METRON-2088-support-hdp-3.1
from
merrimanr:METRON-2225
Closed
METRON-2225: Upgrade to Solr 7.4.0 #1492
merrimanr
wants to merge
6
commits into
apache:feature/METRON-2088-support-hdp-3.1
from
merrimanr:METRON-2225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickwallen
suggested changes
Aug 22, 2019
Contributor
nickwallen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. I have just a few questions.
...n-solr-common/src/test/java/org/apache/metron/solr/integration/components/SolrComponent.java
Show resolved
Hide resolved
...n-solr/metron-solr-common/src/main/java/org/apache/metron/solr/writer/SolrClientFactory.java
Show resolved
Hide resolved
…3.1' into METRON-2225 # Conflicts: # pom.xml
nickwallen
reviewed
Aug 26, 2019
nickwallen
reviewed
Aug 26, 2019
nickwallen
reviewed
Aug 26, 2019
nickwallen
reviewed
Aug 26, 2019
Contributor
|
Before I forget, there are some links in |
…3.1' into METRON-2225 # Conflicts: # pom.xml
Contributor
Author
|
The latest commit updates the README for 7.4. |
nickwallen
approved these changes
Aug 28, 2019
Contributor
nickwallen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 I was able to spin this up successfully. Good updates on the README. Solid. Thanks
asfgit
pushed a commit
that referenced
this pull request
Aug 28, 2019
Contributor
|
This has been merged into the feature branch as ad71c04. |
Closed
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Comments
This PR upgrades Solr from 6.6.2 to 7.4.0.
Changes Included
Testing
Launch the centOS 7 development environment.
Ensure that telemetry is visible within the Alerts UI.
Stop Metron services, Elasticsearch and Kibana.
Install Solr.
Define Solr Collections.
Enable Solr by following these instructions.
Start Metron services.
Ensure that telemetry is visible within the Alerts UI.
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:
For code changes:
Have you included steps to reproduce the behavior or problem that is being changed or addressed?
Have you included steps or a guide to how the change may be verified and tested manually?
Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
Have you written or updated unit tests and or integration tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
For documentation related changes:
Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via
site-book/target/site/index.html:Have you ensured that any documentation diagrams have been updated, along with their source files, using draw.io? See Metron Development Guidelines for instructions.
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.