Skip to content
This repository was archived by the owner on Aug 20, 2025. It is now read-only.

Conversation

@tigerquoll
Copy link
Contributor

@tigerquoll tigerquoll commented Aug 22, 2019

On slower machines the Kafka test harness can timeout on a hardcoded 5 second timeout buried deep in the Kafka test harness code. This patch factors the timeout into a constant and doubles it to 10 seconds, which makes the test pass a lot more reliably on my build host.

Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

  • Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
  • Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

  • Have you included steps to reproduce the behavior or problem that is being changed or addressed?

  • Have you included steps or a guide to how the change may be verified and tested manually?

  • Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:

    mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
    
  • Have you written or updated unit tests and or integration tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

  • Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:

    cd site-book
    mvn site
    
  • Have you ensured that any documentation diagrams have been updated, along with their source files, using draw.io? See Metron Development Guidelines for instructions.

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

…nd increase it to 10 seconds so it doesn't trigger on slower machines
public static final long KAFKA_PROPAGATE_TIMEOUT_MS = 10000l;
public static final int ZK_SESSION_TIMEOUT_MS = 30000;
public static final int ZK_CONNECTION_TIMEOUT_MS = 30000;
public static final int KAFKA_ZOOKEEPER_TIMEOUT_MS = 1000000;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was on the fence about whether this should just be a string or not, but I think having the numeric constants consistently numeric like this makes it a bit cleaner.

@mmiklavc
Copy link
Contributor

Thanks for the contribution. Only 1 minor change regarding the commented out test. Get that resolved and we're good to go. +1 by inspection.

@mmiklavc
Copy link
Contributor

+1

@asfgit asfgit closed this in 67fa5a4 Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants