Skip to content
This repository was archived by the owner on Aug 20, 2025. It is now read-only.

Conversation

@justinleet
Copy link
Contributor

@justinleet justinleet commented Mar 7, 2017

Summary

Following Ryan's work in #453, we have the opportunity to present errors from our topologies.

It's nothing too complicated, essentially just some high level overviews of the various error fields, along with a pane for viewing the actual errors along with all their fields. Note that they include both raw and unique message counts (via the hash fields) in most things.

This also corrects the error_index.template files. These are supposed to match ErrorFields in Constants.java, but didn't.

I've attached some screenshots, and this can be spun up on quick dev and Ambari (both dashboard.p and the various kibana-index.json are updated). Quick dev automatically passes some data through, so it's a good way to get this spun up with something interesting showing.

Feedback on what else would be useful and if we want to adjust anything would be great. Keep in mind, we don't actually have a lot of fields to work with (because if everything was good, we wouldn't be here in the first place!). See error_index.template for the fields we have.

Testing

Spun up in quick-dev and Ambari. Quick-dev will automatically put data through

Notes

  • I'm really not convinced the 'hostname' visualizations are needed. The field is there and useful, but given that it's populated with the Storm host that failed, it seems like it's probably useless most of the time.
  • Kibana occasionally rearranges the order of the visualizations (usually swapping a couple of the charts).
    If I recall correctly, that's a known Kibana bug that we're stuck with.
  • Keep in mind the graph shifts by the viewing window. So last 15 minutes vs last 7 days all updates accordingly.
  • This includes a fix to maps mentioned in METRON-671: Refactor existing Ansible deployment to use Ambari MPack #436. If that PR goes in before this one, this PR should be take it's own copy of the dashboards. If this PR goes in first, that PR should accept this one's dashboards.

screen shot 2017-03-06 at 11 22 20 am

screen shot 2017-03-06 at 11 22 28 am

screen shot 2017-03-06 at 11 22 37 am

screen shot 2017-03-06 at 11 22 45 am

The bottom pane extends further down, but we've all seen a table of data before.

Thank you for submitting a contribution to Apache Metron (Incubating).
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification guildlines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check
the following:

For all changes:

  • Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
  • Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

  • Have you included steps to reproduce the behavior or problem that is being changed or addressed?
  • Have you included steps or a guide to how the change may be verified and tested manually?
  • Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via:
mvn -q clean integration-test install && build_utils/verify_licenses.sh 

- [ ] Have you written or updated unit tests and or integration tests to verify your changes? It's all Kibana UI work, so the testing was done on quick-dev and an Ambari cluster

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html.
cd site-book
bin/generate-md.sh
mvn site:site

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommened that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

@cestella
Copy link
Member

cestella commented Mar 9, 2017

+1 by inspection, great job @justinleet

@asfgit asfgit closed this in b2e46f5 Mar 9, 2017
lucesape pushed a commit to repairnator/repairnator-experiments that referenced this pull request Mar 19, 2017
@justinleet justinleet deleted the METRON-745 branch April 4, 2017 12:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants