METRON-1379: Add an OBJECT_GET stellar function #880
Conversation
justinleet
left a comment
justinleet
left a comment
There was a problem hiding this comment.
Looks good so far, I'll spin it up with the more complete PR, and give feedback if needed.
| public void assertDataIsReadCorrectly(String filename) throws IOException { | ||
| try(BufferedOutputStream bos = new BufferedOutputStream(fs.create(new Path(filename), true))) { | ||
| IOUtils.write(SerDeUtils.toBytes(data), bos); | ||
| bos.flush(); |
There was a problem hiding this comment.
flush() isn't necessary is it? Doesn't close() automatically call flush, and shouldn't try-with-resources take care of that?
Correct me if I'm wrong there, I may be misremembering how this stuff ties together.
There was a problem hiding this comment.
That is not necessarily correct (in general) as Closeable does not enforce flush prior to close (in fact, it doesn't even know about flush()). That being said, strictly speaking, it is not required in this case as it is called for BufferedOutputStream. I have just gotten into the habit of being explicit in calling flush since it's bitten me in the butt so many times in the past. I'm going to take it out in this case as it's not strictly required.
|
I ran this up in the combined PR, and it worked really well. As noted on that ticket, further changes are necessary in the instructions (to handle ES5), but for this ticket looking in ES for the results was sufficient. +1, thanks for the contribution! |
2 participants
Contributor Comments
With the creation of METRON-1378 we have the ability to create serialized summaries of data. We need to interact with these summaries from within Stellar. This enables use-cases like creating a bloom filter of malicious domains and interacting with that bloom filter from within all the places where stellar is available.
Manual Testing
This PR depends on #879 to create summarized objects for testing. As such, the easiest way to manually test this is to actually go through the testing for #882. #882 has the code here merged into it and will be kept up-to-date.
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:
For code changes:
Have you included steps to reproduce the behavior or problem that is being changed or addressed?
Have you included steps or a guide to how the change may be verified and tested manually?
Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
Have you written or updated unit tests and or integration tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
For documentation related changes:
Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via
site-book/target/site/index.html:Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.