This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Replace all test images with images from public domain. #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leezu
reviewed
Feb 3, 2021
Contributor
leezu
left a comment
leezu
left a comment
There was a problem hiding this comment.
Can you include the licensing info somewhere?
added 2 commits
February 2, 2021 16:22
runners.jpg: from https://commons.wikimedia.org/wiki/File:Ludovic_and_Lauren_(8425515069).jpg bikes.jpg: from https://commons.wikimedia.org/wiki/File:V%C3%A9locourse.jpg tennis.jpg: from https://commons.wikimedia.org/wiki/File:Roger_Federer_2012_Indian_Wells.jpg soccer.png: from https://github.com/dmlc/web-data/blob/master/gluoncv/pose/soccer.png
josephevans
force-pushed
the
test_data2
branch
from
2403b4c to
08d9fa9
Compare
Contributor
Author
Thanks for the suggestions @leezu, added the licenses of the images that have one. |
Contributor
|
Thank you @josephevans. I'm not sure if we can use images without license, as we may first need to seek permission from the author to redistribute them here as part of Apache. WDYT? |
josephevans
changed the title
Contributor
Author
|
When this is merged, the onnx tests will start failing. I will open a PR with updated URLs as soon as this is merged. |
.jpg){kind=link}
Contributor
|
Why did we not first fix the tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update LICENSE file to indicate all images in test-data/images are from public domain.