Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[RFC] Custom subgraph property enhancements #17236

@samskalicky

Description

@samskalicky

Description

Request for comments on the next PR for enhancing custom subgraph property support

Heres some suggestions from the initial PR (Part 1):

  • docs, readme, tutorial Dynamic subgraph property doc #17585
  • dynamic graph passes
  • move builds of so's for customOp/subgraphProp from top level directory
  • Load libraries that are found as siblings next to libmxnet.so/dll. This will allow us to package external libraries into the pip wheel (ie. MKLDNN, TensorRT)
  • Load libraries that are specified in an environment variable like MXNET_EXT_LIBS=/path/to/libmylib.so
  • Apply subgraphBackend during bind when specified by an environment variable like MXNET_SUBGRAPH_BACKEND=myProp

Suggestions from the compile PR:

  • Enable removing params that are fully consumed by a subgraph during compilation to avoid duplication of tensor values

References

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions