Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-16] [DO NOT MERGE] Move submodules to 3rdparty#10122

Closed
eric-haibin-lin wants to merge 15 commits intoapache:masterfrom
eric-haibin-lin:dlpack
Closed

[MXNET-16] [DO NOT MERGE] Move submodules to 3rdparty#10122
eric-haibin-lin wants to merge 15 commits intoapache:masterfrom
eric-haibin-lin:dlpack

Conversation

@eric-haibin-lin
Copy link
Copy Markdown
Member

Description

(Brief description on what this PR is about)

Checklist

Essentials

  • Passed code style checking (make lint)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@marcoabreu
Copy link
Copy Markdown
Contributor

@eric-haibin-lin it's working now?

@eric-haibin-lin
Copy link
Copy Markdown
Member Author

Yes CI is working now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants