This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-72] Improve sparse sgd on GPU#10293
Merged
eric-haibin-lin merged 2 commits intoapache:masterfrom Apr 3, 2018
Merged
Conversation
ZiyueHuang
approved these changes
Mar 30, 2018
haojin2
reviewed
Mar 30, 2018
| mom_data[data_i] = momentum * mom_data[data_i] | ||
| - rate * weight_data[data_i] | ||
| - lr * | ||
| mshadow_op::clip::Map(rescale_grad * grad_data[i], |
haojin2
reviewed
Mar 30, 2018
| mom_data[data_i] = momentum * mom_data[data_i] | ||
| - rate * weight_data[data_i] | ||
| - lr * | ||
| mshadow_op::clip::Map(rescale_grad * grad, |
Member
Author
There was a problem hiding this comment.
no particular reason. No new line will make it a 200 character line.
Contributor
There was a problem hiding this comment.
I mean the extra line break for lr * mshadow_op::clip::Map, these two places are inconsistent with what you have on line 52 of optimizer_op.cu below.
Member
Author
There was a problem hiding this comment.
Don't think it's necessary to add/remove that extra line break. Please provide constructive feedbacks/review comments
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
* gpu kernels * update warning msg
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
* gpu kernels * update warning msg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Apply the same optimization in #10062 for sparse sgd.
@ZiyueHuang @haojin2
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments