Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-307] Add utility to get im2rec.py path#10565

Merged
piiswrong merged 5 commits intoapache:masterfrom
ThomasDelteil:patch-11
Apr 16, 2018
Merged

[MXNET-307] Add utility to get im2rec.py path#10565
piiswrong merged 5 commits intoapache:masterfrom
ThomasDelteil:patch-11

Conversation

@ThomasDelteil
Copy link
Copy Markdown
Contributor

Description

Add a utility to get the path to the im2rec.py tool
update the basic/data.md tutorial

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Change strategy to get im2rec_path
@ThomasDelteil ThomasDelteil requested a review from szha as a code owner April 16, 2018 19:18
@ThomasDelteil
Copy link
Copy Markdown
Contributor Author

@anirudh2290 fix we discussed

@anirudh2290
Copy link
Copy Markdown
Member

@eric-haibin-lin would you be able to take a look ? This needs to go in for the release.

@piiswrong piiswrong merged commit 12cbcea into apache:master Apr 16, 2018
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Apr 16, 2018
* Update data.md

Change strategy to get im2rec_path

* Update test_utils.py

* Update data.md

* Update test_utils.py

* Update test_utils.py
eric-haibin-lin pushed a commit that referenced this pull request Apr 17, 2018
* Update data.md

Change strategy to get im2rec_path

* Update test_utils.py

* Update data.md

* Update test_utils.py

* Update test_utils.py
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
* Update data.md

Change strategy to get im2rec_path

* Update test_utils.py

* Update data.md

* Update test_utils.py

* Update test_utils.py
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
* Update data.md

Change strategy to get im2rec_path

* Update test_utils.py

* Update data.md

* Update test_utils.py

* Update test_utils.py
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants