Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Additional v1.2.0 changes - install docs changes, website changes#10606

Merged
eric-haibin-lin merged 2 commits intoapache:v1.2.0from
anirudh2290:v1.2.0
Apr 18, 2018
Merged

Additional v1.2.0 changes - install docs changes, website changes#10606
eric-haibin-lin merged 2 commits intoapache:v1.2.0from
anirudh2290:v1.2.0

Conversation

@anirudh2290
Copy link
Copy Markdown
Member

Description

PR to the release branch to add : #10587 and #10449

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

* Remove pip upgrade step

* Trigger CI

* Fix for GPU too

* Trigger CI
@anirudh2290 anirudh2290 requested a review from szha as a code owner April 18, 2018 20:22
* Changes for SIM AWSDBUX-19875
1. Add ONNX to Docs
2. Move Github to Community
3. ename Gluon Model Zoo to Model Zoo

* Removing Gluon from the Navbar and correcting the link for ONNX

* Re-ordering the elements in the Navbar for SIM AWSDBUX-19875

* In the navbar, changing the Github URL to to apache/incubator-mxnet

* Removing gluon and github from navbar.js

* Adding Gluon back to the Navbar
@anirudh2290 anirudh2290 changed the title [WIP] Additional v1.2.0 changes - install docs changes, website changes Additional v1.2.0 changes - install docs changes, website changes Apr 18, 2018
@anirudh2290
Copy link
Copy Markdown
Member Author

@eric-haibin-lin can this be merged without squashing. We don't have to wait for CI to pass since the CI checks already passed in the corresponding PRs and the changes are disjoint: #10587 and #10449 . Plus, we will make sure that the branch passes all CI tests, including nightlies.

@eric-haibin-lin
Copy link
Copy Markdown
Member

I'll merge these now since they're just cherrypicked commits.

@eric-haibin-lin eric-haibin-lin merged commit 9eba2d1 into apache:v1.2.0 Apr 18, 2018
@anirudh2290
Copy link
Copy Markdown
Member Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants