Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

add Windows support of cython modules#11013

Closed
zchrissirhcz wants to merge 1 commit intoapache:masterfrom
zchrissirhcz:rcnn-windows
Closed

add Windows support of cython modules#11013
zchrissirhcz wants to merge 1 commit intoapache:masterfrom
zchrissirhcz:rcnn-windows

Conversation

@zchrissirhcz
Copy link
Copy Markdown

@zchrissirhcz zchrissirhcz commented May 21, 2018

added scripts are copied and modified from:
DeformableConvNets

Windows users please use run init.bat instead of make to compile cython modules.

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

added scripts are copied and modified from:
[DeformableConvNets](https://github.com/msracver/Deformable-ConvNets)
@zchrissirhcz zchrissirhcz requested a review from szha as a code owner May 21, 2018 09:35
@chinakook
Copy link
Copy Markdown
Contributor

But DeformableConvNets supports python 2 only.

@zchrissirhcz
Copy link
Copy Markdown
Author

@chinakook LoL. I use python2 on windows. I'm not familiar with Python3 so didn't notice this not-compatible problem.

@ijkguo ijkguo mentioned this pull request Jun 27, 2018
3 tasks
@zhreshold
Copy link
Copy Markdown
Member

Since #11373 was merged, it's no longer requiring cython.
I am closing this for now.Let me know if you hold different opinion.

@zhreshold zhreshold closed this Jul 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants