Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Add android64 support and fix build.py#11188

Merged
marcoabreu merged 2 commits intoapache:devel-androidfrom
larroy:devel-android
Jun 7, 2018
Merged

Add android64 support and fix build.py#11188
marcoabreu merged 2 commits intoapache:devel-androidfrom
larroy:devel-android

Conversation

@larroy
Copy link
Copy Markdown
Contributor

@larroy larroy commented Jun 7, 2018

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

larroy added 2 commits June 7, 2018 18:29
Add initial android64 build logic.
Remove pthread when linking MXNet in Android. Bionic provides built-in support for threads.
@larroy larroy requested review from marcoabreu and szha as code owners June 7, 2018 16:44
@marcoabreu marcoabreu merged commit 14e40b9 into apache:devel-android Jun 7, 2018
larroy added a commit to larroy/mxnet that referenced this pull request Jun 8, 2018
* Fix ci/build.py using remote cache locally

* Fixes sources for android64
Add initial android64 build logic.
Remove pthread when linking MXNet in Android. Bionic provides built-in support for threads.
larroy added a commit to larroy/mxnet that referenced this pull request Jun 10, 2018
* Fix ci/build.py using remote cache locally

* Fixes sources for android64
Add initial android64 build logic.
Remove pthread when linking MXNet in Android. Bionic provides built-in support for threads.
larroy added a commit to larroy/mxnet that referenced this pull request Jun 10, 2018
* Fix ci/build.py using remote cache locally

* Fixes sources for android64
Add initial android64 build logic.
Remove pthread when linking MXNet in Android. Bionic provides built-in support for threads.
Simplify and fix android64 build
larroy added a commit to larroy/mxnet that referenced this pull request Jun 10, 2018
* Fix ci/build.py using remote cache locally

* Fixes sources for android64
Add initial android64 build logic.
Remove pthread when linking MXNet in Android. Bionic provides built-in support for threads.
Simplify and fix android64 build
larroy added a commit to larroy/mxnet that referenced this pull request Jun 10, 2018
* Fix ci/build.py using remote cache locally

* Fixes sources for android64
Add initial android64 build logic.
Remove pthread when linking MXNet in Android. Bionic provides built-in support for threads.
Simplify and fix android64 build
larroy added a commit to larroy/mxnet that referenced this pull request Jun 11, 2018
* Fixes sources for android64
Add initial android64 build logic.
Remove pthread when linking MXNet in Android. Bionic provides built-in support for threads.
* Simplify and fix android64 build
larroy added a commit to larroy/mxnet that referenced this pull request Jun 11, 2018
* Fixes sources for android64
Add initial android64 build logic.
Remove pthread when linking MXNet in Android. Bionic provides built-in support for threads.
* Simplify and fix android64 build
larroy added a commit to larroy/mxnet that referenced this pull request Jun 12, 2018
* Fixes sources for android64
Add initial android64 build logic.
Remove pthread when linking MXNet in Android. Bionic provides built-in support for threads.
* Simplify and fix android64 build
larroy added a commit to larroy/mxnet that referenced this pull request Jun 12, 2018
* Fixes sources for android64
Add initial android64 build logic.
Remove pthread when linking MXNet in Android. Bionic provides built-in support for threads.
* Simplify and fix android64 build
marcoabreu pushed a commit that referenced this pull request Jun 15, 2018
* Fixes sources for android64
Add initial android64 build logic.
Remove pthread when linking MXNet in Android. Bionic provides built-in support for threads.
* Simplify and fix android64 build
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
* Fixes sources for android64
Add initial android64 build logic.
Remove pthread when linking MXNet in Android. Bionic provides built-in support for threads.
* Simplify and fix android64 build
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
* Fixes sources for android64
Add initial android64 build logic.
Remove pthread when linking MXNet in Android. Bionic provides built-in support for threads.
* Simplify and fix android64 build
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants