Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Static alloc for hybridblock#11319

Closed
tqchen wants to merge 1 commit intomasterfrom
revert-11318-revert-11313-static
Closed

Static alloc for hybridblock#11319
tqchen wants to merge 1 commit intomasterfrom
revert-11318-revert-11313-static

Conversation

@tqchen
Copy link
Copy Markdown
Member

@tqchen tqchen commented Jun 16, 2018

Bring back the changes of hybrid-blocks. The test coverage issues has been addressed.

@tqchen tqchen requested a review from piiswrong June 16, 2018 01:46
@tqchen tqchen requested a review from szha as a code owner June 16, 2018 01:46
@marcoabreu marcoabreu closed this Jun 16, 2018
@tqchen tqchen reopened this Jun 16, 2018
@tqchen tqchen closed this Jun 16, 2018
@tqchen tqchen deleted the revert-11318-revert-11313-static branch June 16, 2018 02:06
@haojin2
Copy link
Copy Markdown
Contributor

haojin2 commented Jun 16, 2018

@marcoabreu Can we bring this commit back? I've got some work (#11179) that depends of part of this PR.

@eric-haibin-lin
Copy link
Copy Markdown
Member

@marcoabreu My work also depends on this PR. #11306

@marcoabreu
Copy link
Copy Markdown
Contributor

We will prioritize to get this PR back in as soon as possible. Sorry for the caused inconveniences.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants