This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-618] Clojure package - move NDArray and Symbol Code generation to Automatic#11534
Merged
yzhliu merged 1 commit intoapache:masterfrom Jul 3, 2018
Merged
Conversation
…time (AOT) - Do not check in generated files anymore - Add to gitignore
szha
approved these changes
Jul 2, 2018
Contributor
|
Hey Carin, I can't review your PR on my phone due to the number of deleted files. Please excuse if this is already answered. The two processes you described, are they already part of CI or how are we testing it? If something takes a long time, I'm happy to add it to nightly. |
Member
Author
|
@marcoabreu - I put manual testings instructions there. The first part For this PR, if CI tests are green, we are good to go. If someone else wants to test out the |
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
…time (AOT) (apache#11534) - Do not check in generated files anymore - Add to gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
From feedback from the Clojure package PR #11205, this changes the automatic generation of the ndarray and symbol code from a manual step to an automatic compile-time (AOT) step. The generated code is no longer checked into git as well.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Testing
To test this change:
with lein test
src/org/apache/clojure_mxnet/gendirectorylein testsrc/org/apache/clojure_mxnet/genbut ignored by gitwith jars
src/org/apache/clojure_mxnet/gendirectorylein installto create target jarexamples/imclassificationlein runto run the example with the installed jar