Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Fix nccl compilation error#11623

Merged
eric-haibin-lin merged 1 commit intoapache:masterfrom
eric-haibin-lin:fix-nccl
Jul 10, 2018
Merged

Fix nccl compilation error#11623
eric-haibin-lin merged 1 commit intoapache:masterfrom
eric-haibin-lin:fix-nccl

Conversation

@eric-haibin-lin
Copy link
Copy Markdown
Member

@eric-haibin-lin eric-haibin-lin commented Jul 10, 2018

Description

PR #11429 breaks compilation when USE_NCCL is set to 1. @ctcyang @rahul003
Verified with compilation locally and passed tests/python/gpu/test_nccl.py

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Copy link
Copy Markdown
Contributor

@ctcyang ctcyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested tests/python/gpu/test_nccl.py and tools/bandwidth/measure.py --kv-store nccl --gpus 0,1,2,3,4,5,6,7 --network vgg --num-layers 16. Both pass, so looks good to me.

@eric-haibin-lin eric-haibin-lin merged commit 5ff9b92 into apache:master Jul 10, 2018
Copy link
Copy Markdown
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
@eric-haibin-lin eric-haibin-lin deleted the fix-nccl branch November 12, 2018 20:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants