This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-836] RNN Example for Scala#11753
Merged
nswamy merged 7 commits intoapache:masterfrom Aug 21, 2018
Merged
Conversation
This was referenced Jul 16, 2018
7f1a929 to
d94ec27
Compare
lanking520
commented
Jul 22, 2018
Member
Author
lanking520
left a comment
There was a problem hiding this comment.
Please skip these section from your code review as it did not change
nswamy
reviewed
Jul 23, 2018
Member
Author
|
Add download: #11866 |
Member
Member
|
I would like this PR to wait until we have #11844 is merged in so we make sure that DataDesc works with RNN & Bucketing moduel |
Member
Author
|
So I think probably we cannot make this as |
Member
|
@nswamy @lanking520 Thanks for the update :) |
c72dca0 to
9395600
Compare
9395600 to
4fbd52a
Compare
26c037a to
9e420ad
Compare
andrewfayres
approved these changes
Aug 21, 2018
Contributor
andrewfayres
left a comment
There was a problem hiding this comment.
lgtm
Unfortunately github makes looking at this far more confusing than it should be.
Member
|
@lanking520 thanks for fixing the RNN example, @andrewfayres Thanks for the review and yes indeed the whitespace/formatting changes make it hard to look at it. |
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
* initial fix for RNN * add CI test * add encoding format * scala style fix * update readme * test char RNN works * ignore the test due to memory leaks
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
Sep 19, 2018
* initial fix for RNN * add CI test * add encoding format * scala style fix * update readme * test char RNN works * ignore the test due to memory leaks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the example written in new API in Scala. It include the following two tests:
RNN Example not supported for MXNet Scala #11571
@yzhliu @nswamy @andrewfayres
This example also include a change on the DataDesc by defining a default settings for shape size = 2 in
NTformatChecklist
Essentials
Please feel free to remove inapplicable items for your PR.