This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-711] Fixing the version build to show 1.2.1 instead of 1.2.0#11874
Closed
kpmurali wants to merge 3 commits intoapache:masterfrom
Closed
[MXNET-711] Fixing the version build to show 1.2.1 instead of 1.2.0#11874kpmurali wants to merge 3 commits intoapache:masterfrom
kpmurali wants to merge 3 commits intoapache:masterfrom
Conversation
aaronmarkham
suggested changes
Jul 24, 2018
| with open('tag_list.txt', 'r') as tag_file: | ||
| for line in tag_file: | ||
| tag_list.append(line.lstrip().rstrip()) | ||
| tag_list.append(line.lstrip().rstrip().replace("0.12.0","0.12.1").replace("1.2.0","1.2.1")) |
Contributor
There was a problem hiding this comment.
As discussed, please move this logic upstream and hook into the Jenkins job's parameters for the list of tags to display.
Also, please add comments along the way that make it clear what the differences are between the tags to build and the tags to display.
Contributor
There was a problem hiding this comment.
I think we should rather have some generalized logic aka select each major and minor version and the highest patch or just use Aaron proposed method. This replace doesn't look right to me.
Contributor
|
This can be closed in favor of #11892. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixing the version build to show 1.2.1 instead of 1.2.0
Checklist
Changes