Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Add support for networks with multiple outputs in ONNX exporter#12398

Closed
ptrendx wants to merge 2 commits intoapache:masterfrom
ptrendx:onnx_multi_outputs
Closed

Add support for networks with multiple outputs in ONNX exporter#12398
ptrendx wants to merge 2 commits intoapache:masterfrom
ptrendx:onnx_multi_outputs

Conversation

@ptrendx
Copy link
Copy Markdown
Member

@ptrendx ptrendx commented Aug 29, 2018

Description

Add support for networks with multiple outputs to ONNX exporter

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@ptrendx ptrendx requested a review from szha as a code owner August 29, 2018 17:21
@nswamy
Copy link
Copy Markdown
Member

nswamy commented Aug 29, 2018

@Roshrini

@lupesko
Copy link
Copy Markdown
Contributor

lupesko commented Sep 4, 2018

Thanks for the contribution @ptrendx !
@anirudhacharya @vandanavk - to take a look as well.

Copy link
Copy Markdown
Member

@anirudhacharya anirudhacharya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stu1130
Copy link
Copy Markdown
Contributor

stu1130 commented Sep 17, 2018

@ptrendx bounce again! Could you please add a test! Thanks

@vandanavk
Copy link
Copy Markdown
Contributor

@mxnet-label-bot [pr-awaiting-response]

@marcoabreu marcoabreu added the pr-awaiting-response PR is reviewed and waiting for contributor to respond label Sep 24, 2018
@BobLiu20
Copy link
Copy Markdown
Contributor

BobLiu20 commented Oct 8, 2018

Waiting for this PR! Thanks.

@Roshrini
Copy link
Copy Markdown
Member

@ptrendx ping again :)

@ankkhedia
Copy link
Copy Markdown
Contributor

@ptrendx Thanks for the contribution! :)
Could you please look into the review comments?

@ptrendx ptrendx force-pushed the onnx_multi_outputs branch from f213531 to 375997d Compare November 8, 2018 23:13
@kalyc
Copy link
Copy Markdown
Contributor

kalyc commented Nov 13, 2018

@mxnet-label-bot update [pr-awaiting-review]

@marcoabreu marcoabreu added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-response PR is reviewed and waiting for contributor to respond labels Nov 13, 2018
@stu1130
Copy link
Copy Markdown
Contributor

stu1130 commented Nov 20, 2018

@ptrendx thanks for addressing the comment. @anirudhacharya @Roshrini @vandanavk could you please take a look at this? Thanks

@vandanavk
Copy link
Copy Markdown
Contributor

@ptrendx Sina submitted a PR #13390 for multi outputs. Please have a look

@ptrendx
Copy link
Copy Markdown
Member Author

ptrendx commented Nov 27, 2018

Closing then since it achieves the same thing.

@ptrendx ptrendx closed this Nov 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.