This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Infer dtype in SymbolBlock import from input symbol (v1.3.x)#13117
Merged
szha merged 13 commits intoapache:v1.3.xfrom Nov 7, 2018
Merged
Infer dtype in SymbolBlock import from input symbol (v1.3.x)#13117szha merged 13 commits intoapache:v1.3.xfrom
szha merged 13 commits intoapache:v1.3.xfrom
Conversation
Contributor
Author
Contributor
Author
Member
|
A likely easier way to add the changes is to provide a list of commits that committers can cherry-pick. The branch CI will still be triggered after picking. |
Contributor
Author
|
@szha I'm making sure that there are no conflicts by rebasing the changes to the branch. What has been added (for a changelog, for example) would be easier to track and review as well. |
Member
|
@mxnet-label-bot [pr-awaiting-merge] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A port of #12412 to 1.3.x branch.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments