Fix/link to mkl build#13268
Conversation
|
@TaoLv what was the reasoning for not including mkl headers? |
|
Thanks for the fix, @azai91 . This change was merged from #11148 and seems it has been verified on different platforms. I noticed the header missing error on windows build, so I included them back for MSVC path. But I didn't observed any failure for other platforms in the CI. Please refer the CI outputs from #13181 . Also, ping @lebeg for review. |
|
@mxnet-label-bot add [pr-awaiting-review] |
lebeg
left a comment
There was a problem hiding this comment.
It's good to have the problem fixed ASAP, but probably the include should happen not in this file in the future.
|
@mxnet-label-bot udpate [pr-awaiting-merge] |
|
I'm impacted by this, please merge. |
|
@nswamy @sandeep-krishnamurthy @eric-haibin-lin could you please help merge this PR? |
This reverts commit 5042ec3.
Description
Building mxnet with mkldnn in master causes the following error
In in past PR that updated the mkldnn version (#13181) the cmake script was modified that removed including mkl headers. The following PR fixes this.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments