Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Use ~/.ccache as default ccache directory so is not cache is not eras… #13431

Merged
marcoabreu merged 1 commit into from
Nov 30, 2018
Merged

Use ~/.ccache as default ccache directory so is not cache is not eras… #13431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ def default_ccache_dir() -> str:
ccache_dir = "/tmp/_mxnet_ccache"
Copy link
Copy Markdown
Contributor

@lebeg lebeg Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why wouldn't we do that on OSX as well?

Copy link
Copy Markdown
Contributor Author

@larroy larroy Nov 30, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to look at this, but the pr was merged. We can change it in another PR but have to test locally that docker can access the home folder. In the end is mainly for Linux use.

os.makedirs(ccache_dir, exist_ok=True)
return ccache_dir
return os.path.join(tempfile.gettempdir(), "ci_ccache")
return os.path.join(os.path.expanduser("~"), ".ccache")


def trim_container_id(cid):
Expand Down