Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Chi_square_check for discrete distribution fix #13543

Merged
yzhliu merged 6 commits into from
Dec 6, 2018
Merged

Chi_square_check for discrete distribution fix #13543

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4328e30
check for bucket instead of index
ChaiBapchya Dec 5, 2018
c989695
enumerate instead of range(len())
ChaiBapchya Dec 5, 2018
d16dd07
count instead of sum to solve attribute error
ChaiBapchya Dec 5, 2018
128e9f9
revert to sum
ChaiBapchya Dec 5, 2018
7df22dd
seperate discrete and continuous
ChaiBapchya Dec 5, 2018
e3ec9f2
Trigger CI
ChaiBapchya Dec 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions python/mxnet/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1911,12 +1911,15 @@ def chi_square_check(generator, buckets, probs, nsamples=1000000):
if continuous_dist:
sample_bucket_ids = np.searchsorted(buckets_npy, samples, side='right')
else:
sample_bucket_ids = samples
sample_bucket_ids = np.array(samples)
if continuous_dist:
sample_bucket_ids = sample_bucket_ids // 2
obs_freq = np.zeros(shape=len(buckets), dtype=np.int)
for i in range(len(buckets)):
obs_freq[i] = (sample_bucket_ids == i).sum()
for i, _ in enumerate(buckets):
Comment thread
ChaiBapchya marked this conversation as resolved.
if continuous_dist:
obs_freq[i] = (sample_bucket_ids == i).sum()
else:
obs_freq[i] = (sample_bucket_ids == buckets[i]).sum()
Comment thread
ChaiBapchya marked this conversation as resolved.
_, p = ss.chisquare(f_obs=obs_freq, f_exp=expected_freq)
return p, obs_freq, expected_freq

Expand Down