Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

added Fix unpicklable transform_first on windows#13690

Closed
srochel wants to merge 1 commit intoapache:v1.4.xfrom
srochel:patch-4
Closed

added Fix unpicklable transform_first on windows#13690
srochel wants to merge 1 commit intoapache:v1.4.xfrom
srochel:patch-4

Conversation

@srochel
Copy link
Copy Markdown
Contributor

@srochel srochel commented Dec 19, 2018

added * Fix unpicklable transform_first on windows (#13686 )
@eric-haibin-lin still needs to merge this PR and PR 13686 to 1.4.x branch

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

added * Fix unpicklable transform_first on windows (#13686 )
@eric-haibin-lin  still needs to merge this PR and PR 13686 to 1.4.x branch
@astonzhang
Copy link
Copy Markdown
Member

Thanks! The PR with the same change has been merged:
#13691

@srochel srochel closed this Dec 19, 2018
@srochel srochel deleted the patch-4 branch December 19, 2018 23:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants