Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[DO NOT REVIEW] Bring nnvm::Tuple to mxnet::Tuple#14217

Closed
junrushao wants to merge 2 commits intoapache:numpyfrom
junrushao:np-add-tshape
Closed

[DO NOT REVIEW] Bring nnvm::Tuple to mxnet::Tuple#14217
junrushao wants to merge 2 commits intoapache:numpyfrom
junrushao:np-add-tshape

Conversation

@junrushao
Copy link
Member

@junrushao junrushao commented Feb 20, 2019

This is not a PR to master branch, so nothing will be affected.

This PR brought nnvm::Tuple and nnvm::TShape to mxnet, for future improvement of TShape.

CC: @reminisce

@roywei
Copy link
Member

roywei commented Feb 21, 2019

@mxnet-label-bot add[Backend, pr-awaiting-review]

@marcoabreu marcoabreu added Backend Issues related to the backend of MXNet pr-awaiting-review PR is waiting for code review labels Feb 21, 2019
@junrushao
Copy link
Member Author

Most of the migration is done except for the PlanMemory pass, which blocked us from passing CI.

@reminisce
Copy link
Contributor

Is it because PlanMemory expects nnvm::TShape? We need to copy that pass from NNVM to MXNet anyway, so I think you can make a copy of that to pass the CI.

@junrushao
Copy link
Member Author

junrushao commented Feb 27, 2019

Will send this to master's branch. So closing it for now.

#14270

@junrushao junrushao closed this Feb 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Backend Issues related to the backend of MXNet pr-awaiting-review PR is waiting for code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants