Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[v1.4.x][Cherry-Pick] Memory fixes. Resolves #10867, and resolves #14080 (#14372)#14586

Merged
lanking520 merged 1 commit intoapache:v1.4.xfrom
lanking520:cherry-pick-memory
Apr 5, 2019
Merged

[v1.4.x][Cherry-Pick] Memory fixes. Resolves #10867, and resolves #14080 (#14372)#14586
lanking520 merged 1 commit intoapache:v1.4.xfrom
lanking520:cherry-pick-memory

Conversation

@lanking520
Copy link
Copy Markdown
Member

@lanking520 lanking520 commented Apr 1, 2019

Description

Cherry pick #14372 to 1.4.x to fix the potential memory problems.
@zachgk @andrewfayres @nswamy

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@andrewfayres @lanking520
Memory fixes. Resolves apache#10867, and resolves apache#14080 (apach…
d8c63d8 
…e#14372)

* Fixes for memory leak when reshaping executor

* Fixed Adam Optimizer memory leak

* Cleanup for PR

* Added unit test for new ResourceScope method

* Removing import that was added by overzealous ide

* Add back in an import

* Added flags for executor to know whether or not it owns NDArrays for disposal

* Moving to ResourceScope.using implementation

* Changes to make ResourceScope.using work with existing scope

* Updating ResourceScope to work with existing scopes via usingIfScopeExists method

* Fix clojure unit tests

* Fixes to be compatibile with how clojure is using ResourceScope

* Removing some unnecessary changes

* Adding scope assertion in unit test
@lanking520 lanking520 requested review from nswamy and yzhliu as code owners April 1, 2019 22:26
@piyushghai
Copy link
Copy Markdown
Contributor

piyushghai commented Apr 2, 2019

@lanking520 Can you re-trigger the CI ?
TensorRT GPU stage on CI seems to be flaky.

@mxnet-label-bot Add [pr-awaiting-merge, scala, java]

@marcoabreu marcoabreu added Java Label to identify Java API component pr-awaiting-merge Review and CI is complete. Ready to Merge Scala labels Apr 2, 2019
@lanking520
Copy link
Copy Markdown
Member Author

lanking520 commented Apr 2, 2019

@lanking520 Can you re-trigger the CI ?
TensorRT GPU stage on CI seems to be flaky.

@mxnet-label-bot Add [pr-awaiting-merge, scala, java]

Already tried a couple of times yesterday

@piyushghai piyushghai mentioned this pull request Apr 2, 2019
Merged
@lanking520
Copy link
Copy Markdown
Member Author

lanking520 commented Apr 5, 2019

Merge this since the test are unrelated to the changes

@lanking520 lanking520 merged commit c15cbaf into apache:v1.4.x Apr 5, 2019
@lanking520 lanking520 deleted the cherry-pick-memory branch April 8, 2019 18:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yzhliu yzhliu Awaiting requested review from yzhliu yzhliu is a code owner

1 more reviewer

@nswamy nswamy nswamy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Java Label to identify Java API component pr-awaiting-merge Review and CI is complete. Ready to Merge Scala

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lanking520 @piyushghai @nswamy @marcoabreu @andrewfayres