-
Notifications
You must be signed in to change notification settings - Fork 6.7k
An empty NDArray should have size 0 #14717
Conversation
|
@ziyuang Can you add unittest for this change? |
|
Can you confirm that an empty shape represents an empty ndarray in cpp-package? In Python and C++ backend, an empty shape actually represents a scalar tensor. |
The expected behavior is to return 0 when the array is empty; now I do this check directly without touching the shape vector. |
Will add a standalone one under |
|
@ziyuang please fill in the PR description template with relevant details about the changes |
|
@mxnet-label-bot add[pr-awaiting-response] |
|
@mxnet-label-bot remove[pr-awaiting-review] |
|
@ziyuang any update on the PR? Also please fill the PR description with relevant details. |
|
@apeforest For review. |
|
@ziyuang any update on the PR? |
|
Hi, has this zero-size NDArray issue been handled well by #14661 already? |
|
@ziyuang Ping for an update. |
|
@ziyuang please trigger CI and update this PR? |
Description
(Brief description on what this PR is about)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments