This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Add API documentation for upsampling operator with examples#14919
Merged
sandeep-krishnamurthy merged 5 commits intoapache:masterfrom May 9, 2019
Merged
Add API documentation for upsampling operator with examples#14919sandeep-krishnamurthy merged 5 commits intoapache:masterfrom
sandeep-krishnamurthy merged 5 commits intoapache:masterfrom
Conversation
Contributor
|
@mxnet-label-bot add [pr-awaiting-review, Doc] @sandeep-krishnamurthy LGTM. Could you add a link to the preview of the webpage once CI passes? |
aaronmarkham
reviewed
May 9, 2019
Contributor
aaronmarkham
left a comment
aaronmarkham
left a comment
There was a problem hiding this comment.
A couple of suggestions.
Also, in another PR is was suggested by @eric-haibin-lin that the Python examples be placed in a special docs generator class, and the C example be left as pseudo-code.
Co-Authored-By: Aaron Markham <markhama@amazon.com>
Co-Authored-By: Aaron Markham <markhama@amazon.com>
Co-Authored-By: Aaron Markham <markhama@amazon.com>
Author
Makes sense, will make it pseudocode. Other comments addressed. Thanks. |
Author
|
@aaronmarkham - Addressed the comments, made it pseudocode. |
aaronmarkham
approved these changes
May 9, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
…4919) * Add API documentation for upsampling operator with examples * Update src/operator/nn/upsampling.cc Co-Authored-By: Aaron Markham <markhama@amazon.com> * Update src/operator/nn/upsampling.cc Co-Authored-By: Aaron Markham <markhama@amazon.com> * Update src/operator/nn/upsampling.cc Co-Authored-By: Aaron Markham <markhama@amazon.com> * Make API doc example as pseudocode than code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #12970
Upsampling operator did not had valid documentation and example usage leading to issues like - #12970
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
@aaronmarkham @vandanavk - Can you please help review this?