ONNX export: Slice op - Handle None value for ends

[vandanavk]

Description

Fixes #14875

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

• The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
• Changes are complete (i.e. I finished coding on this PR)
• All changes have test coverage:
• Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
• Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
• Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
• Code is well-documented:
• For user-facing API changes, API doc string has been updated.
• For new C++ functions in header files, their functionalities and arguments are documented.
• For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
• Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
• To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

• Handle ends=None in Slip_axis export to ONNX

Comments

• All ONNX export tests passed

[vandanavk]

@mxnet-label-bot add [ONNX, pr-awaiting-review]

[Roshrini]

@vandanavk Thanks for fixing this. Can you please add unit test or model test?

[karan6181]

@vandanavk Did you get the chance to add the unit test or model test ? Thanks!

[piyushghai]

@vandanavk Gentle ping....

[vandanavk]

Working on the test. Will have an update soon.

[karan6181]

@vandanavk any updates on the progress?

[ntomer]

I am awaiting the changes :)

[vandanavk]

This PR is ready for review. Awaiting confirmation from the user too

[ntomer]

Any word on when this might pass review?

[vandanavk]

@Roshrini @anirudhacharya @zhreshold for review

[vandanavk]

Based on offline discussion with @Roshrini, making use of ONNX's "slice_end_out_of_bounds" test instead of writing a custom test

[vandanavk]

All review comments addressed. Awaiting further review comments or approval.

[vandanavk]

@zhreshold for review/merge

[vandanavk]

@mxnet-label-bot update [ONNX, pr-awaiting-merge]

[chouxianyu]

Environment:

• Windows10
• Python3.7
• CPU

Descroption:
I met this problem.
And I tried the solution in 9dcf71d, found a new bug.

Traceback (most recent call last):
File "C:\Program Files\PyCharm2018.1.4\helpers\pydev\pydevd.py", line 1664, in
main()
File "C:\Program Files\PyCharm2018.1.4\helpers\pydev\pydevd.py", line 1658, in main
globals = debugger.run(setup['file'], None, None, is_module)
File "C:\Program Files\PyCharm2018.1.4\helpers\pydev\pydevd.py", line 1068, in run
pydev_imports.execfile(file, globals, locals) # execute the script
File "C:\Program Files\PyCharm2018.1.4\helpers\pydev_pydev_imps_pydev_execfile.py", line 18, in execfile
exec(compile(contents+"\n", file, 'exec'), glob, loc)
File "E:/Study/Programming/Code/FWWBA05/MXNet_Helmet_Detection/ONNXTest.py", line 2, in
export_model('./symbols/darknet53-symbol.json', './symbols/darknet53-0000.params', [(4, 3, 416, 416)], verbose=True)
File "D:\WorkingSoftware\Anaconda3\lib\site-packages\mxnet\contrib\onnx\mx2onnx\export_model.py", line 83, in export_model
verbose=verbose)
File "D:\WorkingSoftware\Anaconda3\lib\site-packages\mxnet\contrib\onnx\mx2onnx\export_onnx.py", line 253, in create_onnx_graph_proto
idx=idx
File "D:\WorkingSoftware\Anaconda3\lib\site-packages\mxnet\contrib\onnx\mx2onnx\export_onnx.py", line 90, in convert_layer
raise AttributeError("No conversion function registered for op type %s yet." % op)
AttributeError: No conversion function registered for op type _arange yet.