Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Conversation

@apeforest
Copy link
Contributor

@apeforest apeforest commented May 21, 2019

Description

Support mul, sin, cos, relu, negative

Merging to this branch for collaboration with other contributors on this feature.

Original PR: #14613

@apeforest apeforest self-assigned this May 21, 2019
@larroy
Copy link
Contributor

larroy commented May 21, 2019

Can you link to your original PR since it had some comments related to this patch?

LGTM to merge in the development branch. A comment in imperative.cc about the inputs that require gradients could help clarify as it's not trivial to understand.

@apeforest apeforest merged commit 8c41b03 into apache:develop/higher_order_grad May 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants