This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Add missing default axis value to symbol.squeeze op #15707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leezu
added a commit
to leezu/gluon-nlp
that referenced
this pull request
Jul 30, 2019
Regression fixed by apache/mxnet#15707
szha
reviewed
Jul 30, 2019
Member
szha
left a comment
szha
left a comment
There was a problem hiding this comment.
We also need a test to catch this case. Maybe add a test for HybridBlock with fluent squeeze in it?
Contributor
|
@mxnet-label-bot Add [pr-awaiting-review, Symbol] |
szha
pushed a commit
to dmlc/gluon-nlp
that referenced
this pull request
Aug 1, 2019
Regression fixed by apache/mxnet#15707
anirudhacharya
pushed a commit
to anirudhacharya/mxnet
that referenced
this pull request
Aug 20, 2019
* Add missing default arg * Add test * add test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #15705