Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Conversation

@kshitij12345
Copy link
Contributor

Description

Inspired by @larroy thread CI and PRs,
Cut down time on test_random.test_shuffle which almost always takes most time in the unix-CPU from what I have seen.
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/PR-15865/3/pipeline/282
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/PR-15865/3/pipeline/279
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/PR-15865/3/pipeline/280
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/PR-15865/3/pipeline/281

Before the changes, takes 495s on my laptop.
After the changes, takes 117s on my laptop.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@kshitij12345
Copy link
Contributor Author

The function :
https://github.com/apache/incubator-mxnet/blob/40593c6f6c20baed98a914d14987db5438c0a5a5/tests/python/unittest/test_random.py#L894-L903

doesn't make much sense on
https://github.com/apache/incubator-mxnet/blob/40593c6f6c20baed98a914d14987db5438c0a5a5/tests/python/unittest/test_random.py#L967
which is where almost 90% of the time is spent.
Is this check necessary for this case? Just removing the check for this particular case will bring time down drastically.

@kshitij12345
Copy link
Contributor Author

Closing as #15882 , handles it more gracefully.

@kshitij12345 kshitij12345 deleted the test/test_shuffle/time branch August 15, 2019 06:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant