This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[MKLDNN] fix int8 elemwise add ut#17166
Merged
pengzhao-intel merged 2 commits intoapache:masterfrom Dec 30, 2019
Merged
Conversation
TaoLv
reviewed
Dec 25, 2019
Member
TaoLv
left a comment
There was a problem hiding this comment.
Could you please add description? What's the problem and why the fix?
ciyongch
reviewed
Dec 26, 2019
| fp32_rslt = output.asnumpy() | ||
| int8_rslt = qoutput.asnumpy()*max_val/0x7fffffff | ||
| assert_almost_equal(int8_rslt, int8_rslt, atol = 1e-4) | ||
| int8_rslt = qoutput.astype(output.dtype)*max_range/0x7fffffff |
Contributor
There was a problem hiding this comment.
How this factor works for both INT32 and INT8output?
Contributor
Author
There was a problem hiding this comment.
this test only covers int32 output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
wrongly assert two int8 result before. change to compare fp32 and int8 results.
@ciyongch @TaoLv @pengzhao-intel
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments