-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Add CustomOp tutorial doc #17241
Add CustomOp tutorial doc #17241
Conversation
|
@samskalicky @mseth10 @wkcn please take a look at the doc |
samskalicky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good first draft!
|
@samskalicky @wkcn resolved all the comments! |
|
@eric-haibin-lin @aaronmarkham can you also take a quick look at the doc, thanks! |
0186ab4 to
3ece00b
Compare
samskalicky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great job @rondogency
wkcn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! LGTM : )
eric-haibin-lin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we update the doc on website on extending mxnet with ops? https://mxnet.apache.org/api
We need to probably update https://mxnet.apache.org/api/faq/new_op with a new section for extending mxnet with an op without rebuilding mxnet.
|
There are multiple docs on writing operators. Shall we consolidate them?
|
|
@eric-haibin-lin Thanks for the review! I will add it to a TODO list with upcoming features and consolidating all docs about writing operators (to give new users a smooth experience) |
aaronmarkham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do I go from running this basic example to consuming the following info for my own op? Maybe even a simple example of customization for a particular use case would help.
|
@mxnet-label-bot add [pr-awaiting-review] |
aaronmarkham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super minor suggestions, not worth another CI run. But, if you have to do it anyways, then please add these minor changes.
|
@aaronmarkham thanks for the approval! I resolved your comments since I have to add license header anyway. |
|
@mxnet-label-bot update [pr-awaiting-merge] |
Description
Add a brief tutorial doc on CustomOp tutorial and examples
This PR is not
Those will be addressed in the coming PRs
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments