-
Notifications
You must be signed in to change notification settings - Fork 6.7k
[NumPy] Add NumPy support for triu #17614
Conversation
haojin2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will re-trigger the CI builds to make this pass.
haojin2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @hzfan Can you take a second look specifically on the ffi part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haojin2 LGTM, with some hints about the clang-tidy error.
|
@mxnet-bot run ci [all] |
|
Jenkins CI successfully triggered : [website, windows-gpu, edge, clang, sanity, unix-cpu, centos-gpu, miscellaneous, unix-gpu, windows-cpu, centos-cpu] |
|
@mxnet-bot run ci [all] |
|
Jenkins CI successfully triggered : [website, sanity, miscellaneous, clang, windows-cpu, centos-gpu, centos-cpu, unix-cpu, windows-gpu, edge, unix-gpu] |
|
@mxnet-bot run ci [centos-cpu] |
|
Jenkins CI successfully triggered : [centos-cpu] |
|
@mxnet-bot run ci [centos-cpu] |
|
Jenkins CI successfully triggered : [centos-cpu] |
* triu * rebase * fix ci * merge * triu new ffi * cpplint * cpplint * ffi benchmark * fix style * merge * fix conflict Co-authored-by: Ubuntu <ubuntu@ip-172-31-8-137.us-east-2.compute.internal> Co-authored-by: Hao Jin <hjjn.amzn@gmail.com>
* triu * rebase * fix ci * merge * triu new ffi * cpplint * cpplint * ffi benchmark * fix style * merge * fix conflict Co-authored-by: Ubuntu <ubuntu@ip-172-31-8-137.us-east-2.compute.internal> Co-authored-by: Hao Jin <hjjn.amzn@gmail.com>
Description
This is directly modified from np.tril
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments