Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] Add op linalg.matrix_rank #18020

Merged
haojin2 merged 1 commit into from
Apr 14, 2020
Merged

[Numpy] Add op linalg.matrix_rank #18020

haojin2 merged 1 commit into from
Apr 14, 2020

Conversation

@DwwWxx
Copy link
Contributor

@DwwWxx DwwWxx commented Apr 10, 2020

Description

Add op linalg.matrix_rank

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@DwwWxx DwwWxx requested a review from szha as a code owner April 10, 2020 17:10
@mxnet-bot
Copy link

mxnet-bot commented Apr 10, 2020

Hey @sjtuWangDing , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [clang, miscellaneous, edge, windows-gpu, unix-cpu, unix-gpu, centos-cpu, website, windows-cpu, centos-gpu, sanity]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@DwwWxx
Copy link
Contributor Author

DwwWxx commented Apr 11, 2020

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Apr 11, 2020

Jenkins CI successfully triggered : [unix-gpu]

@haojin2 haojin2 self-assigned this Apr 11, 2020
@haojin2 haojin2 added the Numpy label Apr 11, 2020
haojin2
haojin2 reviewed Apr 11, 2020
View reviewed changes
haojin2
haojin2 reviewed Apr 11, 2020
View reviewed changes
@DwwWxx DwwWxx force-pushed the linalg_matrix_rank branch 2 times, most recently from 960c47e to 75ffcfe Compare April 11, 2020 05:32
@DwwWxx
Copy link
Contributor Author

DwwWxx commented Apr 11, 2020

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Apr 11, 2020

Jenkins CI successfully triggered : [unix-gpu]

* impl - linalg matrix_rank for cpu and gpu implemented
f8e7683 
* fix - python interface

* impl - ffi for matrix_rank

* impl - ffi benchmark
@DwwWxx DwwWxx force-pushed the linalg_matrix_rank branch from 75ffcfe to f8e7683 Compare April 13, 2020 07:51
@DwwWxx
Copy link
Contributor Author

DwwWxx commented Apr 13, 2020

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Apr 13, 2020

Jenkins CI successfully triggered : [unix-gpu]

@haojin2
Copy link
Contributor

haojin2 commented Apr 13, 2020

@hzfan Can you double check on the ffi part? All the rest LGTM.

hzfan
hzfan approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@hzfan hzfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FFI LGTM

@haojin2 haojin2 merged commit 8e3f0f3 into apache:master Apr 14, 2020
sxjscience pushed a commit to sxjscience/mxnet that referenced this pull request Jul 1, 2020
@DwwWxx @sxjscience
* impl - linalg matrix_rank for cpu and gpu implemented (apache#18020)
ff2dbab 
* fix - python interface

* impl - ffi for matrix_rank

* impl - ffi benchmark

Co-authored-by: Ubuntu <ubuntu@ip-172-31-10-214.us-east-2.compute.internal>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@szha szha Awaiting requested review from szha szha is a code owner

2 more reviewers

@haojin2 haojin2 haojin2 left review comments

@hzfan hzfan hzfan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@haojin2 haojin2

Labels

Numpy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DwwWxx @mxnet-bot @haojin2 @hzfan