Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Conversation

@xziya
Copy link
Contributor

@xziya xziya commented Apr 20, 2020

Description

Previously, we supported FP32 LSTMP and INT8 LSTM operator in #17959 and #18028 using oneDNN v1.4-rc. This PR just upgrade oneDNN to formal v1.4 release.

@ciyongch @TaoLv @pengzhao-intel @sandeep-krishnamurthy @ChaiBapchya

@mxnet-bot
Copy link

Hey @zixuanweeei , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, unix-gpu, windows-cpu, miscellaneous, edge, clang, unix-cpu, sanity, centos-cpu, windows-gpu, website]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@ciyongch
Copy link
Contributor

Please note that this version of oneDNN (with DNNL naming previously) fixes the performance bug of quantize_asym for INT8 LSTM(P) models.

@pengzhao-intel pengzhao-intel changed the title [v1.6.x] Upgrade onednn to its formal v1.4 release [v1.6.x] Upgrade oneDNN to its formal v1.4 release Apr 20, 2020
@pengzhao-intel pengzhao-intel requested a review from TaoLv April 20, 2020 07:40
@pengzhao-intel pengzhao-intel self-assigned this Apr 20, 2020
@xziya
Copy link
Contributor Author

xziya commented Apr 20, 2020

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pengzhao-intel
Copy link
Contributor

I will merge the PR after CI pass :)

@ChaiBapchya
Copy link
Contributor

@pengzhao-intel CI passed! good to merge!

@leezu leezu merged commit 7091576 into apache:v1.6.x Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants