Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Fix Dockerfile.publish.test.centos7#18183

Merged
leezu merged 3 commits intoapache:masterfrom
leezu:fixpublishtestcentos7
Apr 28, 2020
Merged

Fix Dockerfile.publish.test.centos7#18183
leezu merged 3 commits intoapache:masterfrom
leezu:fixpublishtestcentos7

Conversation

@leezu
Copy link
Contributor

@leezu leezu commented Apr 28, 2020

Delete lines missed in prior commit & add CI test to prevent enforce no such mistakes are made in future

Delete lines missed in prior commit.
@mxnet-bot
Copy link

Hey @leezu , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [edge, centos-cpu, unix-gpu, sanity, windows-gpu, centos-gpu, windows-cpu, website, unix-cpu, clang, miscellaneous]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@ChaiBapchya
Copy link
Contributor

ChaiBapchya commented Apr 28, 2020

Thanks for adding that test so as to ensure docker-cache issues are caught earlier.
So basically now if someone wants to make any changes to docker-cache it can be verified using miscellaneous pipeline test.

@leezu
Copy link
Contributor Author

leezu commented Apr 28, 2020

Mainly the tests ensures that all dockerfiles are valid. Not only the ones used in some CI pipeline, but also the ones only used in CD

@leezu leezu merged commit bfd6b41 into apache:master Apr 28, 2020
@leezu leezu deleted the fixpublishtestcentos7 branch April 28, 2020 20:19
AntiZpvoh pushed a commit to AntiZpvoh/incubator-mxnet that referenced this pull request Jul 6, 2020
…e#18183)

Test the job on PRs, to prevent PRs from breaking the production job
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants