-
Notifications
You must be signed in to change notification settings - Fork 6.7k
[1.7.x] Fix memory leaks in Gluon #18358
Conversation
Fix leak of ndarray objects in the frontend due to reference cycle. Backport of 3e676fc
|
Hey @leezu , Thanks for submitting the PR
CI supported jobs: [unix-cpu, unix-gpu, windows-gpu, sanity, clang, centos-gpu, miscellaneous, edge, website, centos-cpu, windows-cpu] Note: |
|
@mxnet-bot run ci [all] |
|
@TaoLv @pengzhao-intel please take a review and help to merge it :) |
|
Please also make sure it's fixed on branch v1.x. |
|
@zhreshold should we revert this PR on the 1.7 and 1.x branch as weakref doesn't work with deepcopy? (Though I'm surprised that |
|
@leezu Fix to mem leak is nice to have and I don't see any problem with this pariticular PR, however, In fact, the behavior of |
This reverts commit c4d9270.
Backport #18328