This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[v1.x] backport #18500 - [Bug Fixed] Fix batch norm when grad_req is add#18518
Merged
szha merged 4 commits intoapache:v1.xfrom Jun 9, 2020
Merged
[v1.x] backport #18500 - [Bug Fixed] Fix batch norm when grad_req is add#18518szha merged 4 commits intoapache:v1.xfrom
add#18518szha merged 4 commits intoapache:v1.xfrom
Conversation
|
Hey @wkcn , Thanks for submitting the PR
CI supported jobs: [windows-cpu, clang, centos-gpu, windows-gpu, miscellaneous, edge, sanity, unix-gpu, unix-cpu, website, centos-cpu] Note: |
Contributor
|
Hi @TaoLv , @pengzhao-intel please help to review and merged. This PR fixed the functionality issue for BN gradient. The corresponding one for master was merged #18500. |
This was referenced Jul 9, 2020
Closed
ChaiBapchya
pushed a commit
to ChaiBapchya/mxnet
that referenced
this pull request
Jul 15, 2020
…eq is `add` (apache#18518) * Fix batch norm when grad_req is * fix * remove softmax test * fix
leezu
pushed a commit
that referenced
this pull request
Jul 23, 2020
…18714) * [Bug Fixed] Fix batch norm when grad_req is `add` (#18500) * fix batch norm when fix_gamma is True * support gradient accumulation for batch norm * mkldnn batchnorm support grad add * unittest for bn * fix bn arg * fix lint * fix mkldnn * fix mkldnn bn * fix grad when fixing gamma * fix naive gpu bn * fix lint * fix cudnn bn * fix flag * fix lint * fix testcase * fix * use @pytest.mark.parametrize * combination * remove redundant test in batchnorm * npx.batch_norm test * try to fix test * reduce the number of tests for batchnorm * fix * Revert "[Bug Fixed] Fix batch norm when grad_req is `add` (#18500)" This reverts commit 8e32cd6. * [v1.x] backport #18500 - [Bug Fixed] Fix batch norm when grad_req is `add` (#18518) * Fix batch norm when grad_req is * fix * remove softmax test * fix * add copy_size * Fix init method for TestBatchNorm Co-authored-by: JackieWu <wkcn@live.cn>
ChaiBapchya
pushed a commit
to ChaiBapchya/mxnet
that referenced
this pull request
Aug 15, 2020
…eq is `add` (apache#18518) * Fix batch norm when grad_req is * fix * remove softmax test * fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bacport #18500
I only change the unit-test to make it compatible with the eldder version of MXNet.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
add#18500Comments