-
Notifications
You must be signed in to change notification settings - Fork 6.7k
[1.x] Revert Fix memory leaks in Gluon in 1.x branch #18706
Conversation
This reverts commit b523527.
|
Hey @rondogency , Thanks for submitting the PR
CI supported jobs: [miscellaneous, windows-gpu, unix-cpu, unix-gpu, windows-cpu, centos-gpu, website, sanity, edge, clang, centos-cpu] Note: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of re-introducing the leak in 1.x branch, we can fix the pickle support by implementing __getstate__ and __setstate__ methods for _BlockScope.
|
@leezu are you patching it in master? That way @rondogency can pick it up here and validate 1.x again. |
|
The issue does not apply to master. |
|
Oh right, I just realized that _BlockScope is gone. |
leezu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's revert first and merge again with the setstate and getstate fix; to ensure any development builds built from 1.x branch remain usable
|
@mxnet-bot run ci [edge, unix-gpu] |
|
Jenkins CI successfully triggered : [edge, unix-gpu] |
|
I think when enabling the branch protection, we accidentally turned on "Require branches to be up to date before merging". I'm requesting to disable it in https://issues.apache.org/jira/browse/INFRA-20616. Don't worry about updating the branch in this PR for now. |
This reverts commit b523527.
This is a continuation of 1.7 revert of the same PR: #18692
Since CD is built on top of 1.x, we should also unblock CD on top of 1.7 release