Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Conversation

@rondogency
Copy link
Contributor

This reverts commit b523527.

This is a continuation of 1.7 revert of the same PR: #18692

Since CD is built on top of 1.x, we should also unblock CD on top of 1.7 release

@rondogency rondogency requested a review from szha as a code owner July 14, 2020 05:59
@mxnet-bot
Copy link

Hey @rondogency , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, windows-gpu, unix-cpu, unix-gpu, windows-cpu, centos-gpu, website, sanity, edge, clang, centos-cpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

Copy link
Contributor

@leezu leezu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of re-introducing the leak in 1.x branch, we can fix the pickle support by implementing __getstate__ and __setstate__ methods for _BlockScope.

@szha
Copy link
Member

szha commented Jul 16, 2020

@leezu are you patching it in master? That way @rondogency can pick it up here and validate 1.x again.

@leezu
Copy link
Contributor

leezu commented Jul 16, 2020

The issue does not apply to master.

@szha
Copy link
Member

szha commented Jul 16, 2020

Oh right, I just realized that _BlockScope is gone.

Copy link
Contributor

@leezu leezu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert first and merge again with the setstate and getstate fix; to ensure any development builds built from 1.x branch remain usable

@rondogency
Copy link
Contributor Author

@mxnet-bot run ci [edge, unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [edge, unix-gpu]

@szha
Copy link
Member

szha commented Jul 30, 2020

I think when enabling the branch protection, we accidentally turned on "Require branches to be up to date before merging". I'm requesting to disable it in https://issues.apache.org/jira/browse/INFRA-20616. Don't worry about updating the branch in this PR for now.

@rondogency rondogency closed this Feb 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants